test: adding test coverage for image resolution codepath #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at coveralls we should also test the user data https://coveralls.io/builds/65030806/source?filename=pkg%2Fproviders%2Fimagefamily%2Fazlinux.go |
tallaxes
requested changes
Jan 12, 2024
tallaxes
added
area/vm-images
This would be naturally taken care of by shifting to Acceptance-style unit tests, I think |
Co-authored-by: Alex Leites <[email protected]>
Co-authored-by: Alex Leites <[email protected]>
…nce, removing old tests
tallaxes
requested changes
Jan 18, 2024
tallaxes
requested changes
Jan 19, 2024
tallaxes
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
In the azure linux pr we just merged in, we did not add coverage for the imageprovider.GET(). This pr adds that missing coverage
How was this change tested?
Its just tests :^)
Does this change impact docs?
Release Note